Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to esmf-bs47 across all platforms; add export of openwater_frac_in_atm from FV3 when coupled #493

Closed

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Mar 29, 2021

PR Checklist

  • Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • If new or updated input data is required by this PR, it is clearly stated in the text of the PR.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

  • Updates ESMF from bs27 to bs47 across all platforms
  • Adds export of openwater_frac_in_atm from FV3 when coupled
  • Adds needed field in fd_nems.yaml

Issue(s) addressed

Testing

ESMF changes: Testing on hera.intel and wcoss-dell-p3 show comparison failures for these tests and files (all other files pass either alt or direct comparison):

fv3_regional_quilt: NATLEV.GrbF00 and NATLEV.GrbF24
fv3_esg_HAFS_v0_hwrf_thompson and fv3_esg_HAFS_v0_hwrf_thompson_debug : phyf000 and dynf000

On dell-p3, some tests failed because of compile failures for 016 and 017 (job killed after reaching LSF run time limit)

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss_cray
  • wcoss_dell_p3

Dependencies

CMEPS #39
FV3-ATM #266

This PR is to be combined with PR #475

@DeniseWorthen DeniseWorthen added the Baseline Updates Current baselines will be updated. label Mar 29, 2021
@DeniseWorthen DeniseWorthen self-assigned this Mar 29, 2021
*merge changes required for export of Sa_ofrac from FV3
* use branch with addition of field to fd_nems.yaml
@DeniseWorthen DeniseWorthen marked this pull request as ready for review March 30, 2021 14:27
@DeniseWorthen DeniseWorthen changed the title Update to esmf-bs47 across all platforms Update to esmf-bs47 across all platforms; add export of openwater_frac_in_atm from FV3 when coupled Mar 30, 2021
@DeniseWorthen
Copy link
Collaborator Author

@junwang-noaa esmf/8.1.0bs47 does not seem to be available on wcoss-cray

I tried:

module use /gpfs/hps3/emc/nems/noscrub/emc.nemspara/soft/modulefiles
module avail

Screen Shot 2021-03-30 at 3 50 57 PM

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 30, 2021 via email

@DeniseWorthen
Copy link
Collaborator Author

Thanks. It looks like it is compiling now.

@DeniseWorthen
Copy link
Collaborator Author

@MinsukJi-NOAA Testing this branch on wcoss-cray gave failures for the alt compare, for example:

Comparing phyf000.tile1.nc ............ALT CHECK......ERROR

Can you take a look? My run directory is /gpfs/hps3/emc/marine/noscrub/Denise.Worthen/ufs_bs47

@MinsukJi-NOAA
Copy link
Contributor

MinsukJi-NOAA commented Mar 30, 2021

@MinsukJi-NOAA Testing this branch on wcoss-cray gave failures for the alt compare, for example:

Comparing phyf000.tile1.nc ............ALT CHECK......ERROR

Can you take a look? My run directory is /gpfs/hps3/emc/marine/noscrub/Denise.Worthen/ufs_bs47

ALT CHECK kicks in when CMP fails. Taking a look at your log file, there are 44 failed test cases of phyf000.tile.1.nc.
I think there are two issues here:

  1. phyf000 is not b4b identical
  2. compare_ncfile.py fail.
    Issue 2 was encountered by @junwang-noaa previously, but I never got to the bottom of it. I will create an issue for this.

@DeniseWorthen
Copy link
Collaborator Author

Thanks Minsuk. I was expecting that the forecast files would need alt check but I was surprised it turned up as "error". The comparison doesn't continue past that so the tests are flagged as failing.

@DeniseWorthen
Copy link
Collaborator Author

I reran the wcoss-cray tests with the forecast files moved to the end of the compare list. All non-forecast files compare "OK" against the current baseline.

@DeniseWorthen
Copy link
Collaborator Author

Merged into PR #475; closing.

DeniseWorthen added a commit that referenced this pull request Apr 5, 2021
…add export of openwater_frac_in_atm from fv3ATM when coupled (#475)


* update CICE in ufs-weather for the latest emc/develop
* fix ice_in_template; sw_redist has been moved to shortwave_nml and removed two unused settings
* update fv3ATM to use esmf-bs47 and add the export of open-water fraction from fv3ATM 
* update module files to use bs47 (PR #493)
* fix wcoss-cray for alt-compare functionality
* update CMEPS and NEMS for added export field
* update Dockerfile
@DeniseWorthen DeniseWorthen deleted the feature/testbs47 branch May 25, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ESMF to bs47 across all platforms
3 participants